Python: Make top level random() raise #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
changed the title
hoodmane
force-pushed
the
hoodmane/no-toplevel-random
branch
from
a458ad2
to
511e04f
Compare
garrettgu10
approved these changes
Apr 3, 2024
dom96
approved these changes
Apr 4, 2024
hoodmane
force-pushed
the
hoodmane/no-toplevel-random
branch
4 times, most recently
from
65f768a
to
89f6af5
Compare
|
Okay I updated this to handle numpy, added more detailed comments and internal tests. |
hoodmane
force-pushed
the
hoodmane/no-toplevel-random
branch
2 times, most recently
from
fef5054
to
0f06a50
Compare
|
Okay, now there is a problem that rust uses randomness for hash seeds: |
hoodmane
force-pushed
the
hoodmane/no-toplevel-random
branch
11 times, most recently
from
698262d
to
2fe472c
Compare
We don't have access to entropy outside of request scope, so `random()` will give poor results. Raise an error if it is called.
hoodmane
force-pushed
the
hoodmane/no-toplevel-random
branch
from
2fe472c
to
aa190bf
Compare
garrettgu10
pushed a commit
that referenced
this pull request
May 13, 2024
We don't have access to entropy outside of request scope, so `random()` will give poor results. Raise an error if it is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have access to entropy outside of request scope, so
random()will give poor results. Raise an error if it is called.