Fix the type of the Hyperdrive binding's port field #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is returned as a number in the implementation of the binding (both in prod and in local development), not a string. This was purely an error in the types.
elithrar
approved these changes
Apr 4, 2024
dom96
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is returned as a number in the implementation of the binding (both in prod and in local development), not a string. This was purely an error in the types.
Noticed in cloudflare/cloudflare-docs#13763 (comment)
Confirmed both by checking the return type in our source code (
uint16_t) and by runningconsole.log(typeof(env.HYPERDRIVE.port));within a worker at the edge and getting backnumber.