Use disk cache to run wd tests #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why is that? Can't we make the R2 bucket accessible from there? |
dom96
reviewed
Apr 5, 2024
garrettgu10
force-pushed
the
ggu/disk-cache-tests
branch
from
9410f42
to
546adcf
Compare
garrettgu10
force-pushed
the
ggu/disk-cache-tests
branch
2 times, most recently
from
5de9c3d
to
b1d765c
Compare
garrettgu10
force-pushed
the
ggu/disk-cache-tests
branch
3 times, most recently
from
f52e195
to
e0ef78b
Compare
Co-authored-by: Dominik Picheta <dominik@cloudflare.com>
garrettgu10
force-pushed
the
ggu/disk-cache-tests
branch
from
e0ef78b
to
9a911e8
Compare
hoodmane
reviewed
May 9, 2024
Comment on lines
9
to
10
| (name = "aiohttp", pythonRequirement = "aiohttp"), | ||
| (name = "ssl", pythonRequirement = "ssl"), |
There was a problem hiding this comment.
Suggested change
| (name = "aiohttp", pythonRequirement = "aiohttp"), | |
| (name = "ssl", pythonRequirement = "ssl"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
all_wheels.zipin its GitHub release.--disk-cache-dirwhen the test is being run.Open questions:
Why not just download the wheels from R2? The main reason is that the R2 bucket is not accessible from our build infrastructure.