[build] Add -fvisibility-inlines-hidden #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
force-pushed
the
felix/visibility-inlines-hidden
branch
from
8150aad
to
6f47928
Compare
Mark C++ inline methods as hidden, causing them to not be exported when creating shared libraries. This significantly reduces binary sizes and possibly link times on Linux, where shared linkage is used for everything except the workerd binary. There is a smaller binary size improvement for macOS, where shared linkage is not enabled by default. See https://gcc.gnu.org/onlinedocs/gcc/C_002b_002b-Dialect-Options.html#index-fvisibility-inlines-hidden for background information.
fhanau
force-pushed
the
felix/visibility-inlines-hidden
branch
from
6f47928
to
c92ae9d
Compare
hoodmane
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark C++ inline methods as hidden, causing them to not be exported when creating shared libraries.
This significantly reduces binary sizes and possibly link times on Linux, where shared linkage is used for everything except the workerd binary (build folder size shrinks 7011MB => 6954 MB based on CI statistics). There is a smaller binary size improvement for macOS, where shared linkage is not enabled by default.
I want to also enable actual hidden visibility (i.e.
-fvisibility=hidden) for V8, but that likely requires significant patching as it is only supported in the V8 GN build so far.See https://gcc.gnu.org/onlinedocs/gcc/C_002b_002b-Dialect-Options.html#index-fvisibility-inlines-hidden for background information.