Add ResolveObserver to jsg/observer.h #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This separates out the new ResolveObserver interface from the new module registry PR in order to make it easier to review and further reduce the size of that other PR. This only adds the definition and does not introduce any code that uses it. That'll come with the module registry PR. The idea is to improve observability of the module resolution process, including tracking the failure cases. For workerd, these observers are non-ops by default but can be set up by embedders to have actual backing implementations.
dom96
approved these changes
Apr 8, 2024
jasnell
commented
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates out the new ResolveObserver interface from the new module registry PR in order to make it easier to review and further reduce the size of that other PR. This only adds the definition and does not introduce any code that uses it. That'll come with the module registry PR.
The idea is to improve observability of the module resolution process, including tracking the failure cases. For workerd, these observers are non-ops by default but can be set up by embedders to have actual backing implementations.
Refs: #1553