Implements Python vectorize API test. #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
reviewed
Apr 11, 2024
Comment on lines
+19
to
+23
| results = await IDX.query(Float32Array.new(res_array), to_js({ | ||
| "topK": 3, | ||
| "returnValues": True, | ||
| "returnMetadata": True, | ||
| })) |
There was a problem hiding this comment.
Suggested change
| results = await IDX.query(Float32Array.new(res_array), to_js({ | |
| "topK": 3, | |
| "returnValues": True, | |
| "returnMetadata": True, | |
| })) | |
| results = await IDX.query(Float32Array.new(res_array), | |
| topK=3, | |
| returnValues=True, | |
| returnMetadata=True) |
There was a problem hiding this comment.
Float32Array.new(res_array) copies res_array. The method then writes the data to this copy and then we throw away the results. If you wanted to get the results written into a Python-accessible location you have to do something like:
from array import array
from pyodide.ffi import create_proxy
pyarray = array("f", [0]*5)
px = create_proxy(pyarray)
buf = px.getBuffer()
await IDX.query(buf.data, ...)There was a problem hiding this comment.
The method doesn't write into that array, it's only an input.
hoodmane
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.