[nfc] Clean up JSG build #2013
Merged
[nfc] Clean up JSG build #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only needed around the time of the switch from 12.0 to 12.1.
fhanau
force-pushed
the
felix/jsg-build-cleanup
branch
from
350de89
to
27ea5ec
Compare
jasnell
approved these changes
Apr 13, 2024
garrettgu10
approved these changes
Apr 14, 2024
|
Everything looks good here but let's be sure to have an internal CI run given the build file changes. |
There is an internal PR (same branch name), it just hasn't been approved yet. |
|
awesome, ok! internal PR stamped! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spiritual successor to #2012. Also see the downstream PR.
This was only needed around the time of the switch from 12.0 to 12.1.