Include the typename T in the error message when checkFarGet fails #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettgu10
approved these changes
Apr 17, 2024
When dereferencing an `IoOwn<T>` fails, include the type name `T` in the error message so that we have a better idea of what went wrong.
jasnell
force-pushed
the
jsnell/include-type-in-io-error-message
branch
from
b59ccee
to
1075cb2
Compare
garrettgu10
pushed a commit
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dereferencing an
IoOwn<T>fails, include the type nameTin the error message so that we have a better idea of what went wrong. It's not likely that this info will be super useful for typical users but could help us better diagnose some of these issues when they occur.