Improve new IoOwn logging #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think allocating a string on every IoOwn is too heavy. And allocating one on every deference is really too heavy. A much better approach would be to pass |
|
That works too :-) ... done |
Avoid allocating the new string on every dereference
jasnell
force-pushed
the
jsnell/improve-ioown-logging
branch
from
03caf07
to
1d589a1
Compare
kentonv
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid allocating the new string on every dereference. The previous iteration was done pretty quickly just to get something we can test with. I imagine we'll keep it so let's make it more performant.