Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce CODE_MOVED error to INFO log. #2037

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Reduce CODE_MOVED error to INFO log. #2037

merged 1 commit into from
Apr 19, 2024

Conversation

kentonv
Copy link
Member

@kentonv kentonv commented Apr 19, 2024

This log message indicates a problem with workerd itself, not with the application -- but it's a benign problem that doesn't cause any issues except possibly making crash dumps slightly less useful. This shouldn't be displayed to application developers, since there's nothing they can or should do about it.

Fixes #1472.

This log message indicates a problem with workerd itself, not with the application -- but it's a benign problem that doesn't cause any issues except possibly making crash dumps slightly less useful. This shouldn't be displayed to application developers, since there's nothing they can or should do about it.

Fixes #1472.
@jasnell jasnell merged commit c817c0c into main Apr 19, 2024
10 checks passed
@jasnell jasnell deleted the kenton/fix-1472 branch April 19, 2024 18:27
@L422Y
Copy link

L422Y commented May 10, 2024

I don't believe this to be entirely benign, at least when using miniflare...
When this error appears, all of my API calls that interact with KV stores also all fail, breaking the application.

@kentonv
Copy link
Member Author

kentonv commented May 10, 2024

@L422Y It must be correlation, not causation. Again, the table being maintained here is only used to improve crash reports from our production environment.

@L422Y
Copy link

L422Y commented May 10, 2024

I suppose my issue is that without this message, I would have had no idea where the problem was originating, so while I agree that it's probably not what causes the issues, maybe hiding it altogether is more detrimental to developer experience than showing it?

@kentonv
Copy link
Member Author

kentonv commented May 10, 2024

This message is not telling you anything about where your problem is originating. It seems it is just coincidentally showing up at the same time as some problem you are experiencing. If anything the message is misleading because it makes you think it has something to do with your problem, when it doesn't.

@L422Y
Copy link

L422Y commented May 10, 2024

I think we should consider all use cases - i.e. local development, where the developer can do something about issues with workerd, and they are entirely more likely to occur.

The issue I experienced was distinctly caused by workerd, and in a development environment, it could have been any number of things, and it turned out to be that workerd does not like it when the system it is invoked on goes to sleep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker error: CODE_MOVED for unknown code block?
4 participants