Update Request to support cache option #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the Request object to support specifying a cache mode per the standard. Only `undefined`, `'no-store'` and `'no-cache'` may be specified, and the fetch implementation specifically does not implement the semantics for either `'no-store'` or `'no-cache'` yet. This just lays the ground work for the additional changes.
jasnell
requested review from
harrishancock,
irvinebroque,
kflansburg and
Warfields
dom96
approved these changes
May 1, 2024
Co-authored-by: Dominik Picheta <dominik@cloudflare.com>
Co-authored-by: Dominik Picheta <dominik@cloudflare.com>
harrishancock
added a commit
that referenced
this pull request
May 12, 2024
This reverts commit bb8c8cd.
harrishancock
added a commit
that referenced
this pull request
May 12, 2024
harrishancock
added a commit
that referenced
this pull request
May 12, 2024
…t-cache Revert "Update Request to support cache option (#2073)"
garrettgu10
pushed a commit
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RM-18292
Updates the Request object to support specifying a cache mode per the standard. Only
undefined,'no-store'and'no-cache'may be specified, and the fetch implementation specifically does not implement the semantics for either'no-store'or'no-cache'yet. This just lays the ground work for the additional changes.The next step is to start adding the support for adding the appropriate header fields in the fetch implementation behind an autogate.