Clean up several UBSan violations #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused a subtle -fsanitize=vptr violation only affecting the test itself.
Trying to mmap an empty file, then releasing the contents caused an empty kj::Array to be created and a new array being created from it, resulting in a "reference binding to null pointer" warning based on the disposer of the empty array being null. Not calling mmap if the file is empty fixes the issue here. It is likely that similar patterns exist in other places, that can be addressed at a future time within capnproto.
jasnell
approved these changes
May 2, 2024
|
Thank you James! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be sufficient to resolve all undefined behavior in workerd code and tests alongside capnproto/capnproto#2021. Also see the downstream PR, where all workerd UBSan tests are passing.
Open to alternative suggestions on how to fix these.