Fail WorkerEntrypoint::connect with a JSG error #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
May 11, 2023
jasnell
reviewed
May 11, 2023
|
(Tagging myself as a DO reviewer, looks pretty reasonable so I doubt I'll be much more than a green check.) |
jasnell
approved these changes
May 11, 2023
|
Why is this needed? Won't the receiving end refuse the connection for now? And eventually we'll actually support this, when we support receiving connections in workers, right? If this needs to be disabled on DO stubs then I would think it also needs to be disabled on service bindings. But I don't see the need, I think we should allow it. |
dom96
force-pushed
the
dominik/disable-connect-on-do
branch
from
4d25122
to
690e162
Compare
dom96
force-pushed
the
dominik/disable-connect-on-do
branch
from
690e162
to
cc029e9
Compare
dom96
changed the title
connect on a Durable Object Fetcher.
kentonv
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
Verified that the gopher example still works with proxy.