Add GitHub Actions. #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently, actions won't work until we make the repo public. |
kentonv
force-pushed
the
kenton/actions
branch
from
9b83f5d
to
49225ea
Compare
jasnell
approved these changes
Sep 20, 2022
dom96
reviewed
Sep 20, 2022
|
I'm not going to merge this until I can actually verify it works, so I guess this PR will sit open for a week. |
|
Note to self: Add a check that bans fixup commits. |
kentonv
force-pushed
the
kenton/actions
branch
from
53f14b5
to
f3b742f
Compare
|
OMG we are going to need to do something about these slow builds. |
|
How about using the builtin bazel cache with a R2 bucket? Happy to do a PR/add on top if so. It would be problematic for forked repos but I guess the step that enables it can be conditional to what the repo is. |
mikea
reviewed
Sep 27, 2022
.github/workflows/test.yml
Outdated
| sudo apt-get install -y build-essential git clang libc++-dev | ||
| - name: bazel tests | ||
| run: | | ||
| bazel test --verbose_failures --test_output=errors //... |
There was a problem hiding this comment.
--show_timestamps is very helpful. I also suggest -k
mikea
approved these changes
Sep 27, 2022
mikea
reviewed
Sep 27, 2022
.github/workflows/test.yml
Outdated
| sudo apt-get install -y build-essential git clang libc++-dev | ||
| - name: bazel tests | ||
| run: | | ||
| bazel test --verbose_failures --test_output=errors //... |
There was a problem hiding this comment.
We run @capnp-cpp//... //... -- -@capnp-cpp//src/capnp:fuzz-test, do we want capnp tests here too?
kentonv
force-pushed
the
kenton/actions
branch
from
f3b742f
to
9ddee5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.