Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] PostgreSQL Support #386

Closed
1 task done
benthecarman opened this issue Sep 17, 2023 · 6 comments · Fixed by #403
Closed
1 task done

[Feature] PostgreSQL Support #386

benthecarman opened this issue Sep 17, 2023 · 6 comments · Fixed by #403

Comments

@benthecarman
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Description

Recently you guys have announced support for various database integrations

https://blog.cloudflare.com/announcing-database-integrations/

https://developers.cloudflare.com/workers/tutorials/postgres

However it is only available for workers in javascript which is untenable for a lot of users.

Would be great if support was added to the rust side

@janpio
Copy link

janpio commented Sep 18, 2023

Isn't that something that would be needed to be fixed in a PostgreSQL driver like tokio-postgres, similar to how it was changed with pg via contribution? Or is the underlying API not surfaced in Rust (yet)?

@kflansburg
Copy link
Member

I believe that we support tokio-postgres after this PR: sfackler/rust-postgres#1040

The current issue is that only plaintext is supported, TLS support is more complex due to the use of StartTLS. We support StartTLS, but tokio postgres would need modification to use this API.

@benthecarman
Copy link
Author

I believe that we support tokio-postgres after this PR: sfackler/rust-postgres#1040

The current issue is that only plaintext is supported, TLS support is more complex due to the use of StartTLS. We support StartTLS, but tokio postgres would need modification to use this API.

Yes I found that, however, because of the no tls it is pretty much unusable for anything in the real world

@kngwyu
Copy link

kngwyu commented Sep 20, 2023

So does it mean that we need a custom TlsConnect implementation based on start_tls? Sounds not very straightforward anyways.

@aviplayer
Copy link

aviplayer commented Nov 13, 2023

Is there any way to provide custom certificate?

@kflansburg
Copy link
Member

Is there any way to provide custom certificate?

TCP sockets for Workers does not currently support custom certificates, but this is on our roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants