Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres TLS Support #403

Merged

Conversation

kflansburg
Copy link
Member

This has been tested and works but the API added to tokio-postgres is hacky and will need some refinement.

Closes #386

@kflansburg kflansburg marked this pull request as ready for review October 23, 2023 19:00
@kflansburg kflansburg requested a review from zebp October 23, 2023 19:00
@bcaimano
Copy link

bcaimano commented Nov 2, 2023

Hmmmmm, looks like some of the commits don't pass the checks on their own. Does it make sense to combine them or maybe just squash on merge?

@kflansburg
Copy link
Member Author

Hmmmmm, looks like some of the commits don't pass the checks on their own. Does it make sense to combine them or maybe just squash on merge?

I typically just squash merge

Copy link

@bcaimano bcaimano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, agree that it feels a touch hacky.

@kflansburg kflansburg merged commit 92a1127 into cloudflare:main Nov 8, 2023
3 checks passed
@kflansburg kflansburg deleted the kflansburg/tokio-postgres-tls branch November 8, 2023 14:07
jdon pushed a commit to jdon/workers-rs that referenced this pull request Mar 27, 2024
* Implement TlsStream for Socket

* starttls trait

* Implement TlsConnection in workers-rs

* Update example

* fmt

* docs and fix example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] PostgreSQL Support
3 participants