-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for cron triggers #104
Conversation
should be because of the await in the macro
@Randoooom - this is great, thank you for working on adding scheduled event triggers. I think we should still include It might seem more complicated at first glance with the old implementation in Let me know if you have any specific request for guidance or commentary on this while its in review. You can also join us on our Discord: https://discord.com/invite/cloudflaredev, where the team can more continuous conversation with you. |
Oh yea, now I see I might be very stupid: I already implemented waitUntil but instead of using |
Not stupid at all - this is impressive work! Keep at it, and let me know how we can help. |
Just resolved the generation of the let shim_content = format!(
r#"
import * as imports from "./{0}.mjs";
const fetch = imports.fetch;
const scheduled = imports.scheduled;
export * from "./{0}.mjs";
export default {{ fetch, scheduled }};
"#,
bg_name
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error handling for wait_until
should be improved.
During my process of fixing this merge conflict, I accidentally managed to squash your commits. But this has been merged, thank you @Randoooom. |
Adds support for cron triggers (resolves #53).
I currently need some inspiration for handling an undefined scheduled event in the
shim.mjs