Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streaming support #143

Merged
merged 3 commits into from
Feb 17, 2022
Merged

Streaming support #143

merged 3 commits into from
Feb 17, 2022

Conversation

zebp
Copy link
Collaborator

@zebp zebp commented Feb 16, 2022

Adds basic streaming support Requests and Responses. This PR is currently blocked on #142 because the wasm-streams library used requires a snippet, so CI will fail until that PR has landed and released.

Manual Testing

Currently to test this PR manually you need to:

  1. Checkout to the Js Snippets PR
  2. Install worker-build system-wide
  3. Checkout to this PR
  4. Comment out the build command from worker-sandbox/wrangler.toml
  5. Manually compile the worker with worker-build --release
  6. Start the worker with miniflare -c ./wrangler.toml --no-cf-fetch --no-update-check
  7. In another terminal session run cargo test xor

@zebp zebp requested a review from nilslice February 16, 2022 19:28
@zebp zebp merged commit f09df35 into main Feb 17, 2022
@zebp zebp deleted the zebp/feat/streaming branch February 17, 2022 21:04
@RyKilleen RyKilleen mentioned this pull request Mar 6, 2022
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilslice nilslice nilslice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zebp @nilslice