Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Response::from_html use text/html; charset=utf-8 #447

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Make Response::from_html use text/html; charset=utf-8 #447

merged 3 commits into from
Feb 28, 2024

Conversation

kpcyrd
Copy link
Contributor

@kpcyrd kpcyrd commented Feb 19, 2024 

Response::from_html("<h1>Hello, World! 馃惐</h1>")

Before

image

After

image

kflansburg
kflansburg previously approved these changes Feb 26, 2024
View reviewed changes
@kflansburg
Copy link
Member

@kpcyrd could you fix formatting?

@kpcyrd
Copy link
Contributor Author

kpcyrd commented Feb 27, 2024

Sure, done!

@kflansburg kflansburg merged commit e6845cc into cloudflare:main Feb 28, 2024
3 checks passed
@kpcyrd kpcyrd deleted the text-html-utf8 branch February 28, 2024 16:05
@andrewdavidmackenzie andrewdavidmackenzie mentioned this pull request Mar 6, 2024
Merged
jdon pushed a commit to jdon/workers-rs that referenced this pull request Mar 27, 2024
@kpcyrd @jdon
Make Response::from_html use text/html; charset=utf-8 (cloudflare#447)
c5dd3ad 
* Make Response::from_html use `text/html; charset=utf-8`

* Make Response::ok use `text/plain; charset=utf-8`

* Fix code formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kflansburg kflansburg kflansburg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kpcyrd @kflansburg