Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃帍 Add ReadableStream to Data #548

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

Jasper-Bekkers
Copy link
Contributor

@Jasper-Bekkers Jasper-Bekkers commented Apr 14, 2024

Sits on top of #547
Better diff: 8709801

Currently Data only exposes FixedLengthStream, however the node.js also allows the ReadableStream to be the argument to put.

https://github.com/cloudflare/workers-sdk/blob/ad1d056cb2710b790ff5d4532e9f694e099c27e2/packages/wrangler/src/r2/helpers.ts#L156

This adds the ability for put and upload_part to forward the ReadableStream from the Request body directly by just passing req.inner().body().unwrap().

@kflansburg
Copy link
Member

@Jasper-Bekkers sorry, just merged, can you rebase?

@Jasper-Bekkers
Copy link
Contributor Author

Rebased.

@kflansburg kflansburg merged commit c76fdc4 into cloudflare:main Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants