Skip to content

Commit

Permalink
fix(wrangler): Show feedback on Pages Function upload failure (#5819)
Browse files Browse the repository at this point in the history
* fix(wrangler): Show feedback on Pages project deployment failure

Today, if uploading a Pages Function, or deploying a Pages
project fails for whatever reason, there’s no feedback shown
to the user. Worse yet, the shown message is misleading,
saying the deployment was successful, when in fact it was not:

```
✨ Deployment complete!
```

This commit ensures that we provide users with:

- the correct feedback with respect to their Pages deployment
- the appropriate messaging depending on the status of their
project's deployment status
- the appropriate logs in case of a deployment failure

* PR review feedback

* fix tests

* add tests

* refactor tests

* PR review fixes 2

---------

Co-authored-by: Carmen Popoviciu <cpopoviciu@cloudflare.com>
  • Loading branch information
CarmenPopoviciu and Carmen Popoviciu committed May 15, 2024
1 parent e6ecf8c commit 63f7acb
Show file tree
Hide file tree
Showing 7 changed files with 3,233 additions and 2,025 deletions.
17 changes: 17 additions & 0 deletions .changeset/nice-waves-sing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
"wrangler": minor
---

fix: Show feedback on Pages project deployment failure

Today, if uploading a Pages Function, or deploying a Pages project fails for whatever reason, there’s no feedback shown to the user. Worse yet, the shown message is misleading, saying the deployment was successful, when in fact it was not:

```
✨ Deployment complete!
```

This commit ensures that we provide users with:

- the correct feedback with respect to their Pages deployment
- the appropriate messaging depending on the status of their project's deployment status
- the appropriate logs in case of a deployment failure

0 comments on commit 63f7acb

Please sign in to comment.