Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install libc++1 in GitHub actions jobs #2173

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Nov 14, 2022

This is required by workerd at runtime. It also looks like this is indirectly required by workerd's install script, so we need to install this any time we call npm ci.

This is required by `workerd` at runtime. It also looks like this is
indirectly required by `workerd`'s install script, so we need to
install this any time we call `npm ci`.
@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2022

⚠️ No Changeset found

Latest commit: 283c602

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3463827880/npm-package-wrangler-2173

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/2173/npm-package-wrangler-2173

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/3463827880/npm-package-wrangler-2173 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.developers.workers.dev/runs/3463827880/npm-package-cloudflare-pages-shared-2173

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #2173 (283c602) into main (ac4deef) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2173      +/-   ##
==========================================
+ Coverage   73.26%   73.28%   +0.01%     
==========================================
  Files         141      141              
  Lines        9087     9087              
  Branches     2369     2369              
==========================================
+ Hits         6658     6659       +1     
+ Misses       2429     2428       -1     
Impacted Files Coverage Δ
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

Copy link
Contributor

@JacobMGEvans JacobMGEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not thrilled this is needed.

@JacobMGEvans JacobMGEvans merged commit 5cba80c into main Nov 14, 2022
@JacobMGEvans JacobMGEvans deleted the bcoll/workerd-ci-deps branch November 14, 2022 20:52
@caass
Copy link
Contributor

caass commented Nov 14, 2022

Is it possible to statically link this in CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants