-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install libc++1
in GitHub actions jobs
#2173
Conversation
This is required by `workerd` at runtime. It also looks like this is indirectly required by `workerd`'s install script, so we need to install this any time we call `npm ci`.
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3463827880/npm-package-wrangler-2173 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/2173/npm-package-wrangler-2173 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/3463827880/npm-package-wrangler-2173 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.developers.workers.dev/runs/3463827880/npm-package-cloudflare-pages-shared-2173 |
Codecov Report
@@ Coverage Diff @@
## main #2173 +/- ##
==========================================
+ Coverage 73.26% 73.28% +0.01%
==========================================
Files 141 141
Lines 9087 9087
Branches 2369 2369
==========================================
+ Hits 6658 6659 +1
+ Misses 2429 2428 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not thrilled this is needed.
Is it possible to statically link this in CI? |
This is required by
workerd
at runtime. It also looks like this is indirectly required byworkerd
's install script, so we need to install this any time we callnpm ci
.