[wrangler] Make wrangler dev --experimental-local the default 🎉

[mrbbot]

Closes #2821
Closes DEVX-605
Closes DEVX-625
Closes DEVX-626
Closes DEVX-634

What this PR solves / how to test:

This PR...

1. Removes the existing --local implementation powered by Miniflare 2
2. Graduates the new --experimental-local implementation powered by Miniflare 3 to --local
3. Makes --local the default
4. Deprecates the --local/--experimental-local flags
5. Adds a new --remote flag to restore the old behaviour

Previously, the --experimental-local implementation was built on-top of the previous --local one. As we're removing --local, this meant there was a lot of untangling to do. We're planning some architectural improvements to wrangler dev soon. To see what these might look like, the new Miniflare 3 implementation has been implemented using the proposed approach, and integrated with the existing system to demonstrate incremental adoptability.

This PR also adds a few missing features/fixes to the --experimental-local implementation:

• Fix source mapping of service worker workers
• Allow use of Durable Objects defined in other workers
• Add support for custom upstreams

In terms of other breaking changes, remote KV storage in local mode has been removed as this is incompatible with Miniflare's new storage system. This was an experimental feature we'll need to rethink. This new storage system also changed the persistence format, invalidating all previously persisted data. To avoid loading invalid data, the default persistence directory has been changed.

Still TODO (wanted to get this PR up so we can start testing the pre-release):

• Add more tests
• Add warning if we detect old persistence directory
• Add message that wrangler dev is now using local mode on first run
• Update changeset with other breaking changes and features

Associated docs issue(s)/PR(s):

• [Workers] wrangler v3 updated local testing docs cloudflare-docs#8691

Author has included the following, where applicable:

• Tests (updated existing tests, but I'd like to add some more)
• Changeset (Changeset guidelines)

Reviewer is to perform the following, as applicable:

• Checked for inclusion of relevant tests
• Checked for inclusion of a relevant changeset
• Checked for creation of associated docs updates
• Manually pulled down the changes and spot-tested

[changeset-bot]

🦋 Changeset detected

Latest commit: 78720c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Major
news-feed-app	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5003291085/npm-package-wrangler-3224

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3224/npm-package-wrangler-3224

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5003291085/npm-package-wrangler-3224 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5003291085/npm-package-cloudflare-pages-shared-3224

Note that these links will no longer work once the GitHub Actions artifact expires.

[JacobMGEvans]

Looks great (for a mammoth PR 😆 ), have some questions before approving

[JacobMGEvans]

Are we certain these Node processes are getting cleaned up after use?

[mrbbot]

Pretty sure. You can't have two processes listening on the same port, so we definitely need separate ports for Wrangler's inspector proxy server and the runtime's inspector server.

[JacobMGEvans]

My concern is creating tons of zombie Node processes holding onto more and more ports.

[codecov]

Codecov Report

Merging #3224 (d688927) into v3 (3050ce7) will increase coverage by 0.73%.
The diff coverage is 58.04%.

❗ Current head d688927 differs from pull request most recent head 26bab6b. Consider uploading reports for the commit 26bab6b to get more accurate results

@@            Coverage Diff             @@
##               v3    #3224      +/-   ##
==========================================
+ Coverage   74.55%   75.29%   +0.73%     
==========================================
  Files         179      180       +1     
  Lines       10969    10895      -74     
  Branches     2922     2851      -71     
==========================================
+ Hits         8178     8203      +25     
+ Misses       2791     2692      -99     

Impacted Files	Coverage Δ
...ges/wrangler/src/dev/get-local-persistence-path.ts	85.71% <ø> (+19.04%)	⬆️
packages/wrangler/src/entry.ts	98.41% <ø> (ø)
...ages/wrangler/src/metrics/metrics-usage-headers.ts	87.50% <ø> (ø)
...ckages/wrangler/src/pages/functions/buildPlugin.ts	19.35% <0.00%> (ø)
packages/wrangler/src/pages/projects.tsx	80.88% <ø> (ø)
packages/wrangler/src/update-check.ts	25.00% <0.00%> (-5.00%)	⬇️
packages/wrangler/src/d1/execute.tsx	52.81% <5.00%> (-4.44%)	⬇️
packages/wrangler/src/index.ts	82.24% <10.00%> (-2.46%)	⬇️
packages/wrangler/src/dev/local.tsx	22.91% <22.72%> (+1.30%)	⬆️
packages/wrangler/src/pages/dev.ts	18.29% <33.33%> (+0.15%)	⬆️
... and 19 more

... and 5 files with indirect coverage changes

Won't block, questions and concerns resolved.

[GregBrimble]

general vibe check for the code from Pages looks good. I want to actually test it a bunch tonight still though.

[GregBrimble]

the rare double approval. gave the Pages functionality a whirl. Looks good to me in practice too ✅✅

[GregBrimble]

Refresh by running npm i on unix machine

[GregBrimble]

Consider adding .wrangler to the .gitignore root of workers-sdk.