Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-cloudflare): use correct start command #3291

Merged
merged 2 commits into from
May 19, 2023

Conversation

Cherry
Copy link
Contributor

@Cherry Cherry commented May 18, 2023

What this PR solves / how to test:

C3 would recommend to use npm run dev previously instead of npm run start, which is what all the templates use. Happy to invert this if preferred.

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@changeset-bot
Copy link

changeset-bot bot commented May 18, 2023

🦋 Changeset detected

Latest commit: 326529b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Cherry Cherry marked this pull request as ready for review May 18, 2023 21:54
@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5018604001/npm-package-wrangler-3291

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3291/npm-package-wrangler-3291

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5018604001/npm-package-wrangler-3291 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5018604001/npm-package-cloudflare-pages-shared-3291

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@bd0a422). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3291   +/-   ##
=======================================
  Coverage        ?   75.44%           
=======================================
  Files           ?      180           
  Lines           ?    11003           
  Branches        ?     2887           
=======================================
  Hits            ?     8301           
  Misses          ?     2702           
  Partials        ?        0           

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this only applies to configs that do not specify a devCommand explicitly.

@petebacondarwin petebacondarwin merged commit c1be44c into cloudflare:main May 19, 2023
11 checks passed
@github-actions github-actions bot mentioned this pull request May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants