Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pages] feat: add wrangler pages project delete command #3293

Merged
merged 1 commit into from May 23, 2023

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented May 19, 2023

What this PR solves / how to test:

Adds a command to delete Pages projects from the command line

Associated docs issue(s)/PR(s):

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2023

🦋 Changeset detected

Latest commit: 25d4044

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin petebacondarwin added the pages Relating to Pages label May 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5022783544/npm-package-wrangler-3293

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3293/npm-package-wrangler-3293

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5022783544/npm-package-wrangler-3293 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5022783544/npm-package-cloudflare-pages-shared-3293

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #3293 (25d4044) into main (99e6ccf) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3293      +/-   ##
==========================================
+ Coverage   75.44%   75.49%   +0.05%     
==========================================
  Files         180      180              
  Lines       11003    11015      +12     
  Branches     2887     2890       +3     
==========================================
+ Hits         8301     8316      +15     
+ Misses       2702     2699       -3     
Impacted Files Coverage Δ
packages/wrangler/src/pages/index.ts 83.33% <ø> (ø)
packages/wrangler/src/pages/projects.tsx 83.75% <100.00%> (+2.86%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@JacobMGEvans JacobMGEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature! Thanks Pete 🎉

@JacobMGEvans JacobMGEvans merged commit 4a88db3 into cloudflare:main May 23, 2023
11 checks passed
@github-actions github-actions bot mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pages Relating to Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants