Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-cloudflare): use tabs by default in prettier configs #3295

Merged
merged 3 commits into from
May 25, 2023

Conversation

Cherry
Copy link
Contributor

@Cherry Cherry commented May 19, 2023

What this PR solves / how to test:

To align with the rest of the repo, and all of the existing previous templates, set useTabs: true on the prettier config that ships with new projects to encourage best practices. The files it generates already use tabs, so this is just aligning the config to match.

It also adds an .editorconfig too to better match the rest of the repo, and improve compat with different editors.

For more reading: #1298

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2023

🦋 Changeset detected

Latest commit: 85e784e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5025767301/npm-package-wrangler-3295

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3295/npm-package-wrangler-3295

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5025767301/npm-package-wrangler-3295 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5025767301/npm-package-cloudflare-pages-shared-3295

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #3295 (85e784e) into main (99e6ccf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3295   +/-   ##
=======================================
  Coverage   75.44%   75.44%           
=======================================
  Files         180      180           
  Lines       11003    11003           
  Branches     2887     2887           
=======================================
  Hits         8301     8301           
  Misses       2702     2702           

@Cherry
Copy link
Contributor Author

Cherry commented May 19, 2023

Test failures seem unrelated to this PR

@Cherry
Copy link
Contributor Author

Cherry commented May 25, 2023

Looks like this is good to merge? 👀 Would be good to land this in c3 early so to set a good precedent and defaults for projects moving forward.

@RamIdeas RamIdeas merged commit 2dc55da into cloudflare:main May 25, 2023
11 checks passed
@Cherry Cherry deleted the fix/c3-prettier-defaults branch May 25, 2023 14:35
@github-actions github-actions bot mentioned this pull request May 25, 2023
@petebacondarwin
Copy link
Contributor

Thanks for this @Cherry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants