Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn that Hyperdrive bindings do not yet work in local dev #4144

Merged

Conversation

a-robinson
Copy link
Member

Support is already in progress (see cloudflare/workerd#1266) and should be coming in the next few weeks, but we've already had at least one user get very confused by this and cause us to spend time on debugging before realizing the problem was that they were talking about problems in wrangler dev rather than at the edge. This is an easy way to attempt to mitigate that for now.

Fixes #4133

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@a-robinson a-robinson requested a review from a team as a code owner October 10, 2023 14:11
@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023

🦋 Changeset detected

Latest commit: 69339ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6502569521/npm-package-wrangler-4144

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6502569521/npm-package-wrangler-4144

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6502569521/npm-package-wrangler-4144 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6502569521/npm-package-cloudflare-pages-shared-4144

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.13.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20231010.0 3.20231010.0
workerd 1.20231010.0 1.20231010.0
workerd --version 1.20231010.0 2023-10-10

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@a-robinson a-robinson force-pushed the arobinson/hyperdrive-local-dev-warning branch 2 times, most recently from 807726e to 463febb Compare October 10, 2023 15:13
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #4144 (69339ab) into main (a08c292) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4144      +/-   ##
==========================================
+ Coverage   75.37%   75.41%   +0.03%     
==========================================
  Files         223      223              
  Lines       12217    12217              
  Branches     3159     3159              
==========================================
+ Hits         9209     9213       +4     
+ Misses       3008     3004       -4     

see 3 files with indirect coverage changes

@a-robinson a-robinson force-pushed the arobinson/hyperdrive-local-dev-warning branch from 5556675 to ba453a4 Compare October 12, 2023 19:06
@a-robinson
Copy link
Member Author

@RamIdeas @rozenmd is one of you able to help get this merged?

Support is already in progress (see
cloudflare/workerd#1266) and should be coming in
the next few weeks, but we've already had at least one user get very
confused by this and cause us to spend time on debugging before
realizing the problem was that they were talking about problems in
wrangler dev rather than at the edge. This is an easy way to attempt to
mitigate that for now.
@a-robinson a-robinson force-pushed the arobinson/hyperdrive-local-dev-warning branch from ba453a4 to 69339ab Compare October 13, 2023 00:46
@a-robinson
Copy link
Member Author

Fixed up yet another merge conflict (which is quite amazing on such a tiny change)

@rozenmd rozenmd merged commit 54800f6 into cloudflare:main Oct 13, 2023
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🐛 BUG: HYPERDRIVE binding is returning as undefined on the env worker param
4 participants