Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for unsafe eval bindings to miniflare #4322

Merged
merged 6 commits into from
Nov 2, 2023

Conversation

dario-piotrowicz
Copy link
Member

No description provided.

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner November 1, 2023 18:11
Copy link

changeset-bot bot commented Nov 1, 2023

🦋 Changeset detected

Latest commit: 2830465

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
miniflare Minor
@cloudflare/pages-shared Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dario-piotrowicz dario-piotrowicz changed the title Unsafe eval miniflare Add support for unsafe eval bindings to miniflare Nov 1, 2023
Copy link
Contributor

github-actions bot commented Nov 1, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6732252267/npm-package-wrangler-4322

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6732252267/npm-package-wrangler-4322

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6732252267/npm-package-wrangler-4322 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6732252267/npm-package-miniflare-4322
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6732252267/npm-package-cloudflare-pages-shared-4322

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.15.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231025.1
workerd 1.20231025.0 1.20231025.0
workerd --version 1.20231025.0 2023-10-25

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #4322 (2830465) into main (a4a89ae) will increase coverage by 0.04%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4322      +/-   ##
==========================================
+ Coverage   75.34%   75.38%   +0.04%     
==========================================
  Files         223      223              
  Lines       12341    12341              
  Branches     3190     3190              
==========================================
+ Hits         9298     9303       +5     
+ Misses       3043     3038       -5     

see 4 files with indirect coverage changes

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 😃 Added a couple minor comments, then I'll approve. 👍

.changeset/tricky-otters-rescue.md Outdated Show resolved Hide resolved
packages/miniflare/test/index.spec.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants