fix(c3): ensure shell scripts work on Windows #4445
Commits on Nov 24, 2023
-
fix: ensure C3 shell scripts work on Windows
Our use of `shell-quote` was causing problems on Windows where it was escaping character (such as `@`) by placing a backslash in front. This made Windows think that such path arguments, were at the root. For example, `npm install -D @cloudflare/workers-types` was being converted to `npm install -D \@cloudflare/workers-types`, which resulted in errors like: ``` npm ERR! enoent ENOENT: no such file or directory, open 'D:\@cloudflare\workers-types\package.json' ``` Now we just rely directly on the Node.js `spawn` API to avoid any shell quoting concerns. This has resulted in a slightly less streamlined experience for people writing C3 plugins, but has the benefit that the developer doesn't have to worry about quoting spawn arguments. Closes #4282
-
-
C3 e2e - clean up test projects according to their type
Previously we only deleted Pages projects - in fact we were trying to delete the Hono (non-Pages) Worker as a Pages project. Now we delete the project based on its type.
-
C3 - framework template fixes for Windows
- do not use bash-style environment variable setting in Docusaurus scripts - do not run TTY interactive e2e tests on Windows
-
-
C3 - update Nuxt template to avoid requiring Windows incompatible she…
…ll environment variable
-
-
C3 e2e - Only cleanup workers and projects that are over 1 hour old
These e2e test workers and projects should be cleaned up as part of the normal test completion. But if the test crashes they may be left orphaned. This change ensures that we do not clean up projects to early while they are still being used.
-
-
-
C3 e2e - recreate test folders for each e2e retry
Previously we were reusing folders after clearing them when retrying a failed test. But this could lead to problems, especially on Windows where clearing out the folder did not always work.
-
-
-
-
C3 e2e - disable global caches for package managers
This commit uses environment variables to tell package managers to put cached files in a local directory rather than a global shared one, which can cause problems with race conditions when running multiple installs at the same time.
-
C3 e2e - don't cancel other matrix jobs if one fails
It is a false optimization to cancel jobs that are likely to pass when another job flakes out.
-
C3 e2e - drop docusaurus and react tests
These jobs tend to flake out and are not providing much of a useful signal.
-
ci: skip fixture tests that exercise the "dev registry"
Reenable when #4241 lands and improves reliability of this test.
-
C3 - ensure shell commands in logging are reasonably quoted
C3 often outputs log messages to the user of commands that are being executed. Users tend to cut and paste these into their terminal to run themselves. This makes sure that these are likely to just work went pasted into their shell.
