Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler] fix: change wrangler (pages) dev to listen on localhost by default #4532

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Nov 30, 2023

Fixes #4239.

What this PR solves / how to test:

Previously, Wrangler listened on all interfaces (*) by default. This change switches wrangler (pages) dev to just listen on local interfaces. Whilst this is technically a breaking change, we've decided the security benefits outweigh the potential disruption caused. If you need to access your dev server from another device on your network, you can use wrangler (pages) dev --ip * to restore the previous behaviour. To test, run wrangler dev and lsof -nPiTCP -sTCP:LISTEN. Observe Wrangler isn't listening on all interfaces.

Author has addressed the following:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@mrbbot mrbbot requested review from a team as code owners November 30, 2023 17:22
Copy link

changeset-bot bot commented Nov 30, 2023

🦋 Changeset detected

Latest commit: 0967ebf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 30, 2023

A create-cloudflare (C3) prerelease is available for testing.
You can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs//npm-package-create-cloudflare-

Note that these links will no longer work once the GitHub Actions artifact expires.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #4532 (0967ebf) into main (7438e5c) will increase coverage by 0.07%.
Report is 23 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4532      +/-   ##
==========================================
+ Coverage   75.25%   75.33%   +0.07%     
==========================================
  Files         226      226              
  Lines       12570    12570              
  Branches     3261     3261              
==========================================
+ Hits         9460     9469       +9     
+ Misses       3110     3101       -9     
Files Coverage Δ
packages/wrangler/src/config/validation.ts 90.10% <100.00%> (ø)
packages/wrangler/src/pages/dev.ts 16.20% <ø> (ø)

... and 5 files with indirect coverage changes

@mrbbot mrbbot merged commit 311ffbd into main Nov 30, 2023
17 checks passed
@mrbbot mrbbot deleted the bcoll/wrangler-3.17.1-hotfix branch November 30, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🚀 Feature Request: Limit local network access in wrangler dev server
4 participants