-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wrangler] fix: change wrangler (pages) dev
to listen on localhost
by default
#4532
Conversation
Require `MF-Op-Secret` header to match `MINIFLARE_PROXY_SECRET` data binding before request processed.
🦋 Changeset detectedLatest commit: 0967ebf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A create-cloudflare (C3) prerelease is available for testing. npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs//npm-package-create-cloudflare- Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4532 +/- ##
==========================================
+ Coverage 75.25% 75.33% +0.07%
==========================================
Files 226 226
Lines 12570 12570
Branches 3261 3261
==========================================
+ Hits 9460 9469 +9
+ Misses 3110 3101 -9
|
Fixes #4239.
What this PR solves / how to test:
Previously, Wrangler listened on all interfaces (
*
) by default. This change switcheswrangler (pages) dev
to just listen on local interfaces. Whilst this is technically a breaking change, we've decided the security benefits outweigh the potential disruption caused. If you need to access your dev server from another device on your network, you can usewrangler (pages) dev --ip *
to restore the previous behaviour. To test, runwrangler dev
andlsof -nPiTCP -sTCP:LISTEN
. Observe Wrangler isn't listening on all interfaces.Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.