-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrangler: Improve hyperdrive create and update to include all current caching settings #5064
wrangler: Improve hyperdrive create and update to include all current caching settings #5064
Conversation
🦋 Changeset detectedLatest commit: 1cf9aad The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | Generic Database Assignment | 1cf9aad | packages/wrangler/src/tests/hyperdrive.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
} | ||
const updated = await updateConfig(config, args.id, database); | ||
|
||
const updated = await patchConfig(config, args.id, database); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This relies on new
PATCH
handler that is not yet available in production. Do not merge until this handler has been released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PATCH handler has been released and is documented here: https://developers.cloudflare.com/api/operations/patch-hyperdrive
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8272026267/npm-package-wrangler-5064 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5064/npm-package-wrangler-5064 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8272026267/npm-package-wrangler-5064 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8272026267/npm-package-create-cloudflare-5064 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8272026267/npm-package-cloudflare-kv-asset-handler-5064 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8272026267/npm-package-miniflare-5064 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8272026267/npm-package-cloudflare-pages-shared-5064 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8272026267/npm-package-cloudflare-vitest-pool-workers-5064 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5064 +/- ##
==========================================
+ Coverage 71.26% 71.43% +0.17%
==========================================
Files 309 309
Lines 16075 16081 +6
Branches 4105 4103 -2
==========================================
+ Hits 11456 11488 +32
+ Misses 4619 4593 -26
|
6a74adf
to
b8eb387
Compare
Bump. This guy should be good to go, the security check is a false alarm. Flagging a secret in a test file. |
cb0bfcc
to
6a16025
Compare
… caching settings
fd3290c
to
1cf9aad
Compare
Fixes # SQC-200
What this PR solves / how to test:
This PR adds more options in the
hyperdrive create
andhyperdrive update
subcommands for users to update all the caching settings of their Hyperdrive configs.Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.