Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate version command #5069

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Deprecate version command #5069

merged 3 commits into from
Mar 15, 2024

Conversation

RamIdeas
Copy link
Contributor

@RamIdeas RamIdeas commented Feb 21, 2024

What this PR solves / how to test:

This PR deprecated the wrangler version command. It does the same thing as wrangler --version which can be used instead. Deprecating because it could cause confusion with the upcoming wrangler versions ... commands.

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: this command was never documented.

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@RamIdeas RamIdeas requested a review from a team as a code owner February 21, 2024 12:58
Copy link

changeset-bot bot commented Feb 21, 2024

🦋 Changeset detected

Latest commit: 762ba81

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 21, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-wrangler-5069

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5069/npm-package-wrangler-5069

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-wrangler-5069 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-create-cloudflare-5069 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-cloudflare-kv-asset-handler-5069
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-miniflare-5069
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-cloudflare-pages-shared-5069
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-cloudflare-vitest-pool-workers-5069

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.34.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240304.2
workerd 1.20240304.0 1.20240304.0
workerd --version 1.20240304.0 2024-03-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.50%. Comparing base (0c535e7) to head (762ba81).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5069      +/-   ##
==========================================
+ Coverage   71.46%   71.50%   +0.03%     
==========================================
  Files         309      309              
  Lines       16097    16098       +1     
  Branches     4111     4111              
==========================================
+ Hits        11504    11511       +7     
+ Misses       4593     4587       -6     
Files Coverage Δ
packages/wrangler/src/index.ts 90.53% <100.00%> (+0.02%) ⬆️

... and 6 files with indirect coverage changes

packages/kv-asset-handler/package.json Outdated Show resolved Hide resolved
setIsTTY(false);

await runWrangler("-v");
expect(std.out).toMatch(version);
});

// This run separately as command handling is different
it("should output current version if !isTTY calling --version", async () => {
it("should output current version if !isTTY calling with `--version` flag", async () => {
setIsTTY(false);

await runWrangler("--version");
expect(std.out).toMatch(version);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
expect(std.out).toMatch(version);
expect(std.out).toMatch(version);
expect(std.warn).toBe("");

`wrangler --version` is already supported and recommended instead
@RamIdeas RamIdeas merged commit 8f79981 into main Mar 15, 2024
15 checks passed
@RamIdeas RamIdeas deleted the deprecate-version-command branch March 15, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants