-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate version
command
#5069
Conversation
🦋 Changeset detectedLatest commit: 762ba81 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-wrangler-5069 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5069/npm-package-wrangler-5069 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-wrangler-5069 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-create-cloudflare-5069 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-cloudflare-kv-asset-handler-5069 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-miniflare-5069 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-cloudflare-pages-shared-5069 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-cloudflare-vitest-pool-workers-5069 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5069 +/- ##
==========================================
+ Coverage 71.46% 71.50% +0.03%
==========================================
Files 309 309
Lines 16097 16098 +1
Branches 4111 4111
==========================================
+ Hits 11504 11511 +7
+ Misses 4593 4587 -6
|
b83ffe6
to
eed76da
Compare
setIsTTY(false); | ||
|
||
await runWrangler("-v"); | ||
expect(std.out).toMatch(version); | ||
}); | ||
|
||
// This run separately as command handling is different | ||
it("should output current version if !isTTY calling --version", async () => { | ||
it("should output current version if !isTTY calling with `--version` flag", async () => { | ||
setIsTTY(false); | ||
|
||
await runWrangler("--version"); | ||
expect(std.out).toMatch(version); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expect(std.out).toMatch(version); | |
expect(std.out).toMatch(version); | |
expect(std.warn).toBe(""); |
`wrangler --version` is already supported and recommended instead
4382e22
to
bd3755b
Compare
bd3755b
to
762ba81
Compare
What this PR solves / how to test:
This PR deprecated the
wrangler version
command. It does the same thing aswrangler --version
which can be used instead. Deprecating because it could cause confusion with the upcomingwrangler versions ...
commands.Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.