[miniflare] fix: ensure magic proxy works when starting on non-local hosts, and IPv6 addresses can be used as hosts
#5133
Conversation
🦋 Changeset detectedLatest commit: 5c813e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8112124723/npm-package-wrangler-5133You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5133/npm-package-wrangler-5133Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8112124723/npm-package-wrangler-5133 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8112124723/npm-package-create-cloudflare-5133 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8112124723/npm-package-cloudflare-kv-asset-handler-5133npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8112124723/npm-package-miniflare-5133npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8112124723/npm-package-cloudflare-pages-shared-5133npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8112124723/npm-package-cloudflare-vitest-pool-workers-5133Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
mrbbot
force-pushed
the
bcoll/magic-host-fixes
branch
from
c9d9ed1
to
5c813e6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5133 +/- ##
==========================================
+ Coverage 70.32% 70.38% +0.06%
==========================================
Files 298 298
Lines 15542 15542
Branches 3999 3999
==========================================
+ Hits 10930 10940 +10
+ Misses 4612 4602 -10 |
| @@ -174,7 +181,7 @@ function validateOptions( | |||
| // Initialise return values | |||
| const pluginSharedOpts = {} as PluginSharedOptions; | |||
| const pluginWorkerOpts = Array.from(Array(workerOpts.length)).map( | |||
| () => ({} as PluginWorkerOptions) | |||
| () => ({}) as PluginWorkerOptions | |||
There was a problem hiding this comment.
I don't think this makes any difference, right?
There was a problem hiding this comment.
I don't think so, just formatted with a different version of Prettier I guess.
What this PR solves / how to test
Fixes #4993.
Previously, if Miniflare was configured to start on a
hostthat wasn't127.0.0.1,::1,*,::, or0.0.0.0, calls toMiniflareAPI methods relying on the magic proxy (e.g.getKVNamespace(),getWorker(), etc.) would fail. This change ensuresworkerdis always accessible to Miniflare's internals, by configuringworkerdwith an additional local-only entry socket in this case. An unrelated issue meant if Miniflare was configured to start on an IPv6host, it could crash. This change also ensures IPv6 addresses are handled correctly.This means
wrangler devcan now use local network and IPv6 address such as192.168.0.10and::1with the--ipflag.To test this, run
wrangler dev --ip ::1infixtures/worker-app. Useifconfigto find your local network IP, and try that out with the--ipflag too.Author has addressed the following