Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python_workers compat flag instead of experimental #5148

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

dom96
Copy link
Contributor

@dom96 dom96 commented Mar 4, 2024

What this PR solves / how to test

The new workerd requires python_workers compat flag for python.

Author has addressed the following

Copy link

changeset-bot bot commented Mar 4, 2024

🦋 Changeset detected

Latest commit: db123b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
miniflare Minor
wrangler Minor
@cloudflare/pages-shared Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dom96 dom96 force-pushed the dominik/python-compat-flag branch from b3aa905 to 99f592b Compare March 4, 2024 10:48
@dom96 dom96 marked this pull request as ready for review March 4, 2024 10:48
@dom96 dom96 requested a review from a team as a code owner March 4, 2024 10:48
Copy link
Contributor

github-actions bot commented Mar 4, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8158165938/npm-package-wrangler-5148

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5148/npm-package-wrangler-5148

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8158165938/npm-package-wrangler-5148 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8158165938/npm-package-create-cloudflare-5148 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8158165938/npm-package-cloudflare-kv-asset-handler-5148
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8158165938/npm-package-miniflare-5148
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8158165938/npm-package-cloudflare-pages-shared-5148
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8158165938/npm-package-cloudflare-vitest-pool-workers-5148

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.30.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240223.0
workerd 1.20240304.0 1.20240304.0
workerd --version 1.20240304.0 2024-03-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating these. We won't be able to land this without a workerd bump to a version that includes the new flag: https://github.com/cloudflare/workers-sdk/actions/runs/8138977567/job/22241061215?pr=5148#step:8:549

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not actually sure this needs a changeset. This PR is only changing tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep it since this PR also updates workerd to the version that requires the new compat flag.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add another changeset for that bump?

@dom96
Copy link
Contributor Author

dom96 commented Mar 4, 2024

@mrbbot I thought that may be the case, here is a bump in the workerd repo cloudflare/workerd#1761

@dom96 dom96 force-pushed the dominik/python-compat-flag branch from 99f592b to d3ba878 Compare March 4, 2024 15:27
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.36%. Comparing base (b0bd413) to head (db123b8).
Report is 18 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5148   +/-   ##
=======================================
  Coverage   70.35%   70.36%           
=======================================
  Files         298      298           
  Lines       15543    15551    +8     
  Branches     4000     4001    +1     
=======================================
+ Hits        10935    10942    +7     
- Misses       4608     4609    +1     

see 10 files with indirect coverage changes

@dom96
Copy link
Contributor Author

dom96 commented Mar 4, 2024

Should be ready for merge

@CarmenPopoviciu
Copy link
Contributor

CarmenPopoviciu commented Mar 4, 2024

@dom96

  • we'll need to add smth like 👇 in the changeset
chore: bump `workerd` to [`1.20240304.0`](https://github.com/cloudflare/workerd/releases/tag/v1.20240304.0)

@dom96 dom96 force-pushed the dominik/python-compat-flag branch from d3ba878 to db123b8 Compare March 5, 2024 14:45
@dom96
Copy link
Contributor Author

dom96 commented Mar 5, 2024

@CarmenPopoviciu @penalosa done

@mrbbot mrbbot merged commit 11951f3 into cloudflare:main Mar 5, 2024
17 checks passed
@workers-devprod workers-devprod mentioned this pull request Mar 5, 2024
@dom96 dom96 deleted the dominik/python-compat-flag branch March 6, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants