fix: ensure tail exits when the WebSocket disconnects #5275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d20e096 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
petebacondarwin
force-pushed
the
tail-disconnects
branch
from
d1ac3c8
to
dfa2f55
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8330703210/npm-package-wrangler-5275You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5275/npm-package-wrangler-5275Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8330703210/npm-package-wrangler-5275 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8330703210/npm-package-create-cloudflare-5275 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8330703210/npm-package-cloudflare-kv-asset-handler-5275npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8330703210/npm-package-miniflare-5275npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8330703210/npm-package-cloudflare-pages-shared-5275npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8330703210/npm-package-cloudflare-vitest-pool-workers-5275Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
petebacondarwin
force-pushed
the
tail-disconnects
branch
from
dfa2f55
to
22417d7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5275 +/- ##
==========================================
+ Coverage 71.46% 71.56% +0.09%
==========================================
Files 309 311 +2
Lines 16098 16195 +97
Branches 4111 4143 +32
==========================================
+ Hits 11505 11590 +85
- Misses 4593 4605 +12
|
Skye-31
reviewed
Mar 18, 2024
Previously when the we tail WebSocket disconnected, e.g. because of an Internet failure, the `wrangler tail` command would just hang and neither exit nor any longer receive tail messages. Now the process exits with an exit code of 1, and outputs an error message. The error message is formatted appropriately, if the tail format is set to `json`. Fixes #3927
petebacondarwin
force-pushed
the
tail-disconnects
branch
2 times, most recently
from
49741fe
to
c3cb875
Compare
RamIdeas
approved these changes
Mar 18, 2024
Skye-31
reviewed
Mar 18, 2024
petebacondarwin
force-pushed
the
tail-disconnects
branch
from
c3cb875
to
d20e096
Compare
Skye-31
approved these changes
Mar 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves
Previously when the we tail WebSocket disconnected, e.g. because of an Internet failure,
the
wrangler tailcommand would just hang and neither exit nor any longer receive tail messages.Now the process exits with an exit code of 1, and outputs an error message.
The error message is formatted appropriately, if the tail format is set to
json.Fixes #3927
How to test
Automated tests have been added.
But you can test this manually by building Wrangler locally, tailing any Worker and then manually turning off the Internet connection. After 2 secs Wrangler should exit with a suitable error message.
Author has addressed the following