Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wrangler pages functions build-env #5279

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Mar 18, 2024

What this PR solves / how to test

This adds a hidden wrangler pages functions build-env command, which prints the environment variables for the current environment to the terminal. This is for use by internal tooling, and shouldn't be used directly by end users.

Fixes DEVX-1179

Author has addressed the following

Copy link

changeset-bot bot commented Mar 18, 2024

🦋 Changeset detected

Latest commit: c790b5c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@penalosa penalosa marked this pull request as ready for review March 18, 2024 19:01
@penalosa penalosa requested review from a team as code owners March 18, 2024 19:01
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8332188947/npm-package-wrangler-5279

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5279/npm-package-wrangler-5279

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8332188947/npm-package-wrangler-5279 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8332188947/npm-package-create-cloudflare-5279 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8332188947/npm-package-cloudflare-kv-asset-handler-5279
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8332188947/npm-package-miniflare-5279
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8332188947/npm-package-cloudflare-pages-shared-5279
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8332188947/npm-package-cloudflare-vitest-pool-workers-5279

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.34.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240304.2
workerd 1.20240314.0 1.20240314.0
workerd --version 1.20240314.0 2024-03-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.64%. Comparing base (1720f0a) to head (c790b5c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5279      +/-   ##
==========================================
+ Coverage   71.49%   71.64%   +0.15%     
==========================================
  Files         311      312       +1     
  Lines       16170    16208      +38     
  Branches     4137     4144       +7     
==========================================
+ Hits        11561    11613      +52     
+ Misses       4609     4595      -14     
Files Coverage Δ
packages/wrangler/src/config/config.ts 100.00% <ø> (ø)
packages/wrangler/src/config/index.ts 88.82% <100.00%> (+3.19%) ⬆️
packages/wrangler/src/config/validation-pages.ts 97.61% <ø> (ø)
packages/wrangler/src/pages/build-env.ts 100.00% <100.00%> (ø)
packages/wrangler/src/pages/index.ts 84.61% <100.00%> (+0.61%) ⬆️

... and 9 files with indirect coverage changes

@CarmenPopoviciu
Copy link
Contributor

LGTM! Thx for working on this!

@penalosa penalosa merged commit 0a86050 into main Mar 18, 2024
15 checks passed
@penalosa penalosa deleted the penalosa/hidden-build-env branch March 18, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants