Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create & delete commands for R2 event notifications #5294

Merged

Conversation

mattdeboard
Copy link
Contributor

@mattdeboard mattdeboard commented Mar 19, 2024

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

  • Tests
    • Included
  • Changeset (Changeset guidelines)
    • Included
  • Public documentation
    • Not necessary because: This is for a feature pre-release for which documentation has not been created.

@mattdeboard mattdeboard requested a review from a team as a code owner March 19, 2024 15:00
Copy link

changeset-bot bot commented Mar 19, 2024

🦋 Changeset detected

Latest commit: 5dd61f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 19, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8365437601/npm-package-wrangler-5294

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5294/npm-package-wrangler-5294

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8365437601/npm-package-wrangler-5294 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8365437601/npm-package-create-cloudflare-5294 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8365437601/npm-package-cloudflare-kv-asset-handler-5294
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8365437601/npm-package-miniflare-5294
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8365437601/npm-package-cloudflare-pages-shared-5294
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8365437601/npm-package-cloudflare-vitest-pool-workers-5294

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.36.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240314.0
workerd 1.20240314.0 1.20240314.0
workerd --version 1.20240314.0 2024-03-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@mattdeboard mattdeboard force-pushed the add-event-notification-command branch from 784d152 to 0230a3b Compare March 19, 2024 15:13
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.13%. Comparing base (62f1fce) to head (5dd61f2).
Report is 22 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5294      +/-   ##
==========================================
+ Coverage   71.66%   72.13%   +0.47%     
==========================================
  Files         312      313       +1     
  Lines       16208    16290      +82     
  Branches     4144     4161      +17     
==========================================
+ Hits        11615    11751     +136     
+ Misses       4593     4539      -54     
Files Coverage Δ
packages/wrangler/src/r2/helpers.ts 90.82% <100.00%> (+2.87%) ⬆️
packages/wrangler/src/r2/index.ts 88.20% <100.00%> (+1.73%) ⬆️

... and 20 files with indirect coverage changes

@mattdeboard mattdeboard force-pushed the add-event-notification-command branch 2 times, most recently from 8a3148b to 0fb3d86 Compare March 19, 2024 19:19
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. One small nit in the test.

packages/wrangler/src/__tests__/r2/helpers.test.ts Outdated Show resolved Hide resolved
@mattdeboard mattdeboard force-pushed the add-event-notification-command branch from 1f6b91f to c3129c8 Compare March 20, 2024 20:06
mattdeboard and others added 6 commits March 20, 2024 15:26
For beta of this feature, we'll only expose the categories of actions we want to support.
Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
EWC no longer supports including `bucketName` and `queue` in the request body, since these values are already present in the URL.
@mattdeboard mattdeboard force-pushed the add-event-notification-command branch from 078514f to 5dd61f2 Compare March 20, 2024 20:26
@petebacondarwin petebacondarwin merged commit bdc121d into cloudflare:main Mar 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants