-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add create & delete commands for R2 event notifications #5294
Add create & delete commands for R2 event notifications #5294
Conversation
🦋 Changeset detectedLatest commit: 5dd61f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8365437601/npm-package-wrangler-5294 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5294/npm-package-wrangler-5294 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8365437601/npm-package-wrangler-5294 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8365437601/npm-package-create-cloudflare-5294 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8365437601/npm-package-cloudflare-kv-asset-handler-5294 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8365437601/npm-package-miniflare-5294 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8365437601/npm-package-cloudflare-pages-shared-5294 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8365437601/npm-package-cloudflare-vitest-pool-workers-5294 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
784d152
to
0230a3b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5294 +/- ##
==========================================
+ Coverage 71.66% 72.13% +0.47%
==========================================
Files 312 313 +1
Lines 16208 16290 +82
Branches 4144 4161 +17
==========================================
+ Hits 11615 11751 +136
+ Misses 4593 4539 -54
|
8a3148b
to
0fb3d86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. One small nit in the test.
1f6b91f
to
c3129c8
Compare
For beta of this feature, we'll only expose the categories of actions we want to support.
Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
EWC no longer supports including `bucketName` and `queue` in the request body, since these values are already present in the URL.
078514f
to
5dd61f2
Compare
What this PR solves / how to test
Fixes #[insert GH or internal issue number(s)].
Author has addressed the following