-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate pages dev's proxy features #5317
Conversation
🦋 Changeset detectedLatest commit: 5aaaed7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8360882587/npm-package-wrangler-5317 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5317/npm-package-wrangler-5317 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8360882587/npm-package-wrangler-5317 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8360882587/npm-package-create-cloudflare-5317 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8360882587/npm-package-cloudflare-kv-asset-handler-5317 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8360882587/npm-package-miniflare-5317 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8360882587/npm-package-cloudflare-pages-shared-5317 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8360882587/npm-package-cloudflare-vitest-pool-workers-5317 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5317 +/- ##
==========================================
+ Coverage 71.66% 72.01% +0.34%
==========================================
Files 313 313
Lines 16230 16235 +5
Branches 4151 4153 +2
==========================================
+ Hits 11632 11692 +60
+ Misses 4598 4543 -55
|
7b6c28b
to
b56e300
Compare
@@ -37,6 +37,47 @@ describe("pages", () => { | |||
`); | |||
}); | |||
|
|||
describe("deprecation message for deprecated options", () => { | |||
it("should display for 'pages dev -- <command>'", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for --proxy
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b56e300
to
5aaaed7
Compare
Thanks to @GregBrimble I've been hinted to this PR. I just wonder how the dev workflow is without proxying a dev server, such as |
What this PR solves / how to test
Fixes #5211, #5315.
Author has addressed the following