Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate pages dev's proxy features #5317

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

GregBrimble
Copy link
Member

@GregBrimble GregBrimble commented Mar 20, 2024

What this PR solves / how to test

Fixes #5211, #5315.

Author has addressed the following

Copy link

changeset-bot bot commented Mar 20, 2024

🦋 Changeset detected

Latest commit: 5aaaed7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 20, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8360882587/npm-package-wrangler-5317

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5317/npm-package-wrangler-5317

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8360882587/npm-package-wrangler-5317 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8360882587/npm-package-create-cloudflare-5317 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8360882587/npm-package-cloudflare-kv-asset-handler-5317
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8360882587/npm-package-miniflare-5317
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8360882587/npm-package-cloudflare-pages-shared-5317
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8360882587/npm-package-cloudflare-vitest-pool-workers-5317

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.35.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240314.0
workerd 1.20240314.0 1.20240314.0
workerd --version 1.20240314.0 2024-03-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.01%. Comparing base (2eb6cf4) to head (5aaaed7).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5317      +/-   ##
==========================================
+ Coverage   71.66%   72.01%   +0.34%     
==========================================
  Files         313      313              
  Lines       16230    16235       +5     
  Branches     4151     4153       +2     
==========================================
+ Hits        11632    11692      +60     
+ Misses       4598     4543      -55     
Files Coverage Δ
packages/wrangler/src/pages/dev.ts 35.09% <100.00%> (+18.93%) ⬆️

... and 5 files with indirect coverage changes

@GregBrimble GregBrimble marked this pull request as ready for review March 20, 2024 13:51
@GregBrimble GregBrimble requested review from a team as code owners March 20, 2024 13:51
@GregBrimble GregBrimble added this to the Wrangler v4 milestone Mar 20, 2024
@@ -37,6 +37,47 @@ describe("pages", () => {
`);
});

describe("deprecation message for deprecated options", () => {
it("should display for 'pages dev -- <command>'", async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for --proxy?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petebacondarwin petebacondarwin added the e2e Run e2e tests on a PR label Mar 20, 2024
@newsve
Copy link

newsve commented Mar 20, 2024

Thanks to @GregBrimble I've been hinted to this PR. I just wonder how the dev workflow is without proxying a dev server, such as vite dev. I get the consumable Cloudflare build once I build but not while developing, I wrote more here: #5315 (comment)

@GregBrimble GregBrimble merged commit 9fd7eba into main Mar 20, 2024
20 checks passed
@GregBrimble GregBrimble deleted the deprecate-pages-dev-proxy branch March 20, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Deprecate wrangler pages dev -- <PROXY_COMMAND>
3 participants