-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement --experimental-versions
flag + aliases
#5321
Conversation
+ alias: --x-versions + alias: --experimental-gradual-rollouts
🦋 Changeset detectedLatest commit: 7c57dfe The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
--experimental-versions
flag + aliases
8d505cd
to
7c57dfe
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8361150452/npm-package-wrangler-5321 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5321/npm-package-wrangler-5321 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8361150452/npm-package-wrangler-5321 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8361150452/npm-package-create-cloudflare-5321 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8361150452/npm-package-cloudflare-kv-asset-handler-5321 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8361150452/npm-package-miniflare-5321 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8361150452/npm-package-cloudflare-pages-shared-5321 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8361150452/npm-package-cloudflare-vitest-pool-workers-5321 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5321 +/- ##
==========================================
+ Coverage 71.64% 71.71% +0.06%
==========================================
Files 312 313 +1
Lines 16217 16233 +16
Branches 4149 4154 +5
==========================================
+ Hits 11619 11641 +22
+ Misses 4598 4592 -6
|
What this PR solves / how to test
Implement
--experimental-versions
flag--x-versions
(shorthand for convenience)--experimental-gradual-rollouts
(for backwards compat)This change is heading in the direction of a more general approach of formalising experimental flags (and potentially allowing alternate enablement like env vars and/or wrangler.toml properties) and having a
--x-foo
shorthand for--experimental-foo
flags, but this PR implements the convention just for--experimental-versions
with the more general approach to come in a follow-up.Author has addressed the following