Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement --experimental-versions flag + aliases #5321

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Conversation

RamIdeas
Copy link
Contributor

@RamIdeas RamIdeas commented Mar 20, 2024

What this PR solves / how to test

Implement --experimental-versions flag

  • alias: --x-versions (shorthand for convenience)
  • alias: --experimental-gradual-rollouts (for backwards compat)

This change is heading in the direction of a more general approach of formalising experimental flags (and potentially allowing alternate enablement like env vars and/or wrangler.toml properties) and having a --x-foo shorthand for --experimental-foo flags, but this PR implements the convention just for --experimental-versions with the more general approach to come in a follow-up.

Author has addressed the following

@RamIdeas RamIdeas requested a review from a team as a code owner March 20, 2024 14:58
Copy link

changeset-bot bot commented Mar 20, 2024

🦋 Changeset detected

Latest commit: 7c57dfe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@RamIdeas RamIdeas changed the title implement --experimental-versions flag + aliases implement --experimental-versions flag + aliases Mar 20, 2024
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8361150452/npm-package-wrangler-5321

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5321/npm-package-wrangler-5321

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8361150452/npm-package-wrangler-5321 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8361150452/npm-package-create-cloudflare-5321 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8361150452/npm-package-cloudflare-kv-asset-handler-5321
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8361150452/npm-package-miniflare-5321
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8361150452/npm-package-cloudflare-pages-shared-5321
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8361150452/npm-package-cloudflare-vitest-pool-workers-5321

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.35.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240314.0
workerd 1.20240314.0 1.20240314.0
workerd --version 1.20240314.0 2024-03-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.71%. Comparing base (93150aa) to head (7c57dfe).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5321      +/-   ##
==========================================
+ Coverage   71.64%   71.71%   +0.06%     
==========================================
  Files         312      313       +1     
  Lines       16217    16233      +16     
  Branches     4149     4154       +5     
==========================================
+ Hits        11619    11641      +22     
+ Misses       4598     4592       -6     
Files Coverage Δ
packages/wrangler/src/index.ts 90.62% <100.00%> (+0.08%) ⬆️

... and 9 files with indirect coverage changes

@RamIdeas RamIdeas merged commit ac93411 into main Mar 20, 2024
15 checks passed
@RamIdeas RamIdeas deleted the x-versions-flag branch March 20, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants