-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 backport: Ignore OPTIONS requests in Oauth server #5337
Conversation
🦋 Changeset detectedLatest commit: e8d9aa8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2-maintenance #5337 +/- ##
=================================================
Coverage ? 74.53%
=================================================
Files ? 179
Lines ? 10941
Branches ? 2912
=================================================
Hits ? 8155
Misses ? 2786
Partials ? 0
|
"wrangler": patch | ||
--- | ||
|
||
fix: Ignore OPTIONS requests in Wrangler's oauth server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is a backport of the other changeset, but as I commented there, I think it would be helpful to include information about symptoms of the problem that the user would have seen and the fact that this was needed to fix a change in Chrome, mentioning the version etc, so that it makes it easier for users to identify this release as solving that problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth just calling out the error messages that people might see:
Expired! Auth code or refresh token needs to be renewed.
and
ErrorInvalidGrant
Thanks for taking this on @RamIdeas |
What this PR solves / how to test
This PR backports the fix (for
wrangler login
to work with Chrome v123) to wrangler v2. This patch has already been applied to wrangler v3 in #5324.Fixes #5328
Author has addressed the following