Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 backport: Ignore OPTIONS requests in Oauth server #5337

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

RamIdeas
Copy link
Contributor

@RamIdeas RamIdeas commented Mar 21, 2024

What this PR solves / how to test

This PR backports the fix (for wrangler login to work with Chrome v123) to wrangler v2. This patch has already been applied to wrangler v3 in #5324.

Fixes #5328

Author has addressed the following

@RamIdeas RamIdeas requested a review from a team as a code owner March 21, 2024 11:50
Copy link

changeset-bot bot commented Mar 21, 2024

🦋 Changeset detected

Latest commit: e8d9aa8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v2-maintenance@da90e6a). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             v2-maintenance    #5337   +/-   ##
=================================================
  Coverage                  ?   74.53%           
=================================================
  Files                     ?      179           
  Lines                     ?    10941           
  Branches                  ?     2912           
=================================================
  Hits                      ?     8155           
  Misses                    ?     2786           
  Partials                  ?        0           
Files Coverage Δ
packages/wrangler/src/user/user.ts 72.38% <100.00%> (ø)

"wrangler": patch
---

fix: Ignore OPTIONS requests in Wrangler's oauth server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a backport of the other changeset, but as I commented there, I think it would be helpful to include information about symptoms of the problem that the user would have seen and the fact that this was needed to fix a change in Chrome, mentioning the version etc, so that it makes it easier for users to identify this release as solving that problem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth just calling out the error messages that people might see:

Expired! Auth code or refresh token needs to be renewed.

and

ErrorInvalidGrant

@petebacondarwin
Copy link
Contributor

Thanks for taking this on @RamIdeas

@RamIdeas RamIdeas merged commit 35660e2 into v2-maintenance Mar 21, 2024
11 checks passed
@RamIdeas RamIdeas deleted the backport-login-fix branch March 21, 2024 13:49
@github-actions github-actions bot mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants