New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor time-travel compatibility check #5553
Conversation
🦋 Changeset detectedLatest commit: 0a20fb9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8600193705/npm-package-wrangler-5553 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5553/npm-package-wrangler-5553 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8600193705/npm-package-wrangler-5553 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8600193705/npm-package-create-cloudflare-5553 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8600193705/npm-package-cloudflare-kv-asset-handler-5553 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8600193705/npm-package-miniflare-5553 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8600193705/npm-package-cloudflare-pages-shared-5553 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8600193705/npm-package-cloudflare-vitest-pool-workers-5553 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any tests that check this stuff?
There are now @petebacondarwin - btw I think you might need to unlock merging for workers-sdk? |
What this PR solves / how to test
Instead of checking for "beta", we should check for alpha.
Author has addressed the following