-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for wrappedBindings
and RPC entrypoints to Miniflare's Magic Proxy
#5599
Add basic support for wrappedBindings
and RPC entrypoints to Miniflare's Magic Proxy
#5599
Conversation
🦋 Changeset detectedLatest commit: 8fdc2b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8692725908/npm-package-wrangler-5599 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5599/npm-package-wrangler-5599 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8692725908/npm-package-wrangler-5599 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8692725908/npm-package-create-cloudflare-5599 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8692725908/npm-package-cloudflare-kv-asset-handler-5599 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8692725908/npm-package-miniflare-5599 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8692725908/npm-package-cloudflare-pages-shared-5599 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8692725908/npm-package-cloudflare-vitest-pool-workers-5599 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
With the correct env variables the wrangler AI e2e passes locally: on Github I think we need to make sure that the I don't think I have permissions to do the above, maybe someone could help me? 🙂 @petebacondarwin? 🙏 |
--------- Co-authored-by: Samuel Macleod <smacleod@cloudflare.com>
…oxy()` --------- Co-authored-by: Samuel Macleod <smacleod@cloudflare.com>
5b767f0
to
c071182
Compare
Note The I think I've already got a solution for this: 01fa456 but I'd prefer not to scope creep this PR and try to lend it asap instead of piling stuff on top of it |
c071182
to
375aed1
Compare
--------- Co-authored-by: Samuel Macleod <smacleod@cloudflare.com>
375aed1
to
895c520
Compare
wrappedBindings
and RPC entrypoints to Miniflare's Magic Proxy
add test for Miniflare#getBindings() wrapped bindings support
fix indentation in changeset
What this PR solves / how to test
This fixes a number of issues with the Miniflare magic proxy, including:
getPlatformProxy
doesn't provide an AI binding when it should #5575getBindings
does not properly expose RPC entrypoints #5577 (partial support, not including stubs or calling returned functions)Author has addressed the following