Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wrangler): broken link in cli #5616

Merged
merged 4 commits into from Apr 19, 2024

Conversation

webbertakken
Copy link
Contributor

@webbertakken webbertakken commented Apr 14, 2024

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

image

Author has addressed the following

@webbertakken webbertakken requested a review from a team as a code owner April 14, 2024 17:14
Copy link

changeset-bot bot commented Apr 14, 2024

🦋 Changeset detected

Latest commit: 4405524

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 15, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8750644567/npm-package-wrangler-5616

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5616/npm-package-wrangler-5616

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8750644567/npm-package-wrangler-5616 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8750644567/npm-package-create-cloudflare-5616 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8750644567/npm-package-cloudflare-kv-asset-handler-5616
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8750644567/npm-package-miniflare-5616
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8750644567/npm-package-cloudflare-pages-shared-5616
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8750644567/npm-package-cloudflare-vitest-pool-workers-5616

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.51.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240405.2
workerd 1.20240405.0 1.20240405.0
workerd --version 1.20240405.0 2024-04-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu
Copy link
Contributor

CarmenPopoviciu commented Apr 15, 2024

looks like some snapshots are failing. can you please have a look @webbertakken 🙏 ?

@CarmenPopoviciu CarmenPopoviciu added the awaiting reporter response Needs clarification or followup from OP label Apr 15, 2024
@webbertakken
Copy link
Contributor Author

Sorry I'm having trouble getting your repo to work on Windows.

Guide seems to also be missing Windows steps: https://github.com/cloudflare/workers-sdk/blob/main/CONTRIBUTING.md#install-dependencies.

Anyway way you could update the snapshot?

@petebacondarwin petebacondarwin self-assigned this Apr 17, 2024
@petebacondarwin petebacondarwin force-pushed the fix-broken-link branch 2 times, most recently from 27d4926 to a8ab409 Compare April 17, 2024 09:38
@petebacondarwin petebacondarwin removed the awaiting reporter response Needs clarification or followup from OP label Apr 17, 2024
This potentially causes CI failures if the job runs in a different locale
@petebacondarwin petebacondarwin merged commit c6312b5 into cloudflare:main Apr 19, 2024
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants