-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load sourcemaps relative to entry directory #5744
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8928143743/npm-package-wrangler-5744 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5744/npm-package-wrangler-5744 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8928143743/npm-package-wrangler-5744 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8928143743/npm-package-create-cloudflare-5744 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8928143743/npm-package-cloudflare-kv-asset-handler-5744 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8928143743/npm-package-miniflare-5744 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8928143743/npm-package-cloudflare-pages-shared-5744 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8928143743/npm-package-cloudflare-vitest-pool-workers-5744 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
expectedMainModule: "index.js", | ||
expectedModules: { | ||
"index.js.map": expect.stringContaining( | ||
`"sources":["../../another.ts","../../index.ts"],"sourceRoot":""` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this test explicitly specify the file
field of this? It's critical that it matches the name of a file in the multipart but has .map
otherwise the stacktrace remapper in the runtime can't correlate module names to sourcemaps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(not that I think this PR would chance that field, but we should have been explicitly testing this in the first place)
701bd39
to
d1be9c3
Compare
d1be9c3
to
50e90bc
Compare
What this PR solves / how to test
Load sourcemaps relative to the entry directory, not cwd.
Fixes CUSTESC-40775.
Author has addressed the following