Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load sourcemaps relative to entry directory #5744

Merged
merged 1 commit into from
May 2, 2024

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented May 2, 2024

What this PR solves / how to test

Load sourcemaps relative to the entry directory, not cwd.

Fixes CUSTESC-40775.

Author has addressed the following

@penalosa penalosa requested a review from a team as a code owner May 2, 2024 13:35
Copy link

changeset-bot bot commented May 2, 2024

⚠️ No Changeset found

Latest commit: 50e90bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented May 2, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8928143743/npm-package-wrangler-5744

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5744/npm-package-wrangler-5744

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8928143743/npm-package-wrangler-5744 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8928143743/npm-package-create-cloudflare-5744 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8928143743/npm-package-cloudflare-kv-asset-handler-5744
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8928143743/npm-package-miniflare-5744
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8928143743/npm-package-cloudflare-pages-shared-5744
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8928143743/npm-package-cloudflare-vitest-pool-workers-5744

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.53.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240419.0
workerd 1.20240419.0 1.20240419.0
workerd --version 1.20240419.0 2024-04-19

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

expectedMainModule: "index.js",
expectedModules: {
"index.js.map": expect.stringContaining(
`"sources":["../../another.ts","../../index.ts"],"sourceRoot":""`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this test explicitly specify the file field of this? It's critical that it matches the name of a file in the multipart but has .map otherwise the stacktrace remapper in the runtime can't correlate module names to sourcemaps.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not that I think this PR would chance that field, but we should have been explicitly testing this in the first place)

@penalosa penalosa force-pushed the penalosa/relative-source-maps branch from 701bd39 to d1be9c3 Compare May 2, 2024 15:42
@penalosa penalosa force-pushed the penalosa/relative-source-maps branch from d1be9c3 to 50e90bc Compare May 2, 2024 17:42
@penalosa penalosa merged commit c7068b6 into main May 2, 2024
12 checks passed
@penalosa penalosa deleted the penalosa/relative-source-maps branch May 2, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants