fix: do not allow non-string values in bulk secret uploads #5832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0b05314 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9097919564/npm-package-wrangler-5832You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5832/npm-package-wrangler-5832Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9097919564/npm-package-wrangler-5832 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9097919564/npm-package-create-cloudflare-5832 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9097919564/npm-package-cloudflare-kv-asset-handler-5832npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9097919564/npm-package-miniflare-5832npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9097919564/npm-package-cloudflare-pages-shared-5832npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9097919564/npm-package-cloudflare-vitest-pool-workers-5832Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
petebacondarwin
force-pushed
the
validate-bulk-secrets
branch
from
58c9690
to
c995db7
Compare
penalosa
approved these changes
May 15, 2024
Prior to Wrangler 3.4.0 we displayed an error if the user tried to upload a JSON file that contained non-string secrets, since these are not supported by the Cloudflare backend. This change reintroduces that check to give the user a helpful error message rather than a cryptic `workers.api.error.invalid_script_config` error code.
petebacondarwin
force-pushed
the
validate-bulk-secrets
branch
from
c995db7
to
0b05314
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
Prior to Wrangler 3.4.0 we displayed an error if the user tried to upload a JSON file that contained non-string secrets, since these are not supported by the Cloudflare backend.
This change reintroduces that check to give the user a helpful error message rather than a cryptic
workers.api.error.invalid_script_configerror code.Author has addressed the following