Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links #5898

Merged
merged 7 commits into from
May 30, 2024
Merged

Fix links #5898

merged 7 commits into from
May 30, 2024

Conversation

KPCOFGS
Copy link
Contributor

@KPCOFGS KPCOFGS commented May 23, 2024

What this PR solves / how to test

Fixed several links. Tested and they all looked good to me

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: Only fixed links
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: Only fixed links
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: Only changed links
  • Public documentation

@KPCOFGS KPCOFGS requested a review from a team as a code owner May 23, 2024 02:05
Copy link

changeset-bot bot commented May 23, 2024

⚠️ No Changeset found

Latest commit: b170b53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CarmenPopoviciu
Copy link
Contributor

hi @KPCOFGS,

Thank you so much for creating this PR and fixing those links <3. I left a couple of suggestions, but LGTM otherwise. As soon as my comments are addressed we're good to merge this 🌟

@KPCOFGS
Copy link
Contributor Author

KPCOFGS commented May 30, 2024

Hi! Thank you for your feedback! I just did these changes and ready for review

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9301604269/npm-package-wrangler-5898

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5898/npm-package-wrangler-5898

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9301604269/npm-package-wrangler-5898 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9301604269/npm-package-create-cloudflare-5898 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9301604269/npm-package-cloudflare-kv-asset-handler-5898
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9301604269/npm-package-miniflare-5898
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9301604269/npm-package-cloudflare-pages-shared-5898
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9301604269/npm-package-cloudflare-vitest-pool-workers-5898

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.57.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240524.0
workerd 1.20240524.0 1.20240524.0
workerd --version 1.20240524.0 2024-05-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu
Copy link
Contributor

thank you s much @KPCOFGS for your contribution ❤️ !! Merging...

@CarmenPopoviciu CarmenPopoviciu merged commit ee63d31 into cloudflare:main May 30, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants