-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links #5898
Fix links #5898
Conversation
|
hi @KPCOFGS, Thank you so much for creating this PR and fixing those links <3. I left a couple of suggestions, but LGTM otherwise. As soon as my comments are addressed we're good to merge this 🌟 |
Hi! Thank you for your feedback! I just did these changes and ready for review |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9301604269/npm-package-wrangler-5898 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5898/npm-package-wrangler-5898 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9301604269/npm-package-wrangler-5898 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9301604269/npm-package-create-cloudflare-5898 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9301604269/npm-package-cloudflare-kv-asset-handler-5898 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9301604269/npm-package-miniflare-5898 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9301604269/npm-package-cloudflare-pages-shared-5898 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9301604269/npm-package-cloudflare-vitest-pool-workers-5898 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
thank you s much @KPCOFGS for your contribution ❤️ !! Merging... |
What this PR solves / how to test
Fixed several links. Tested and they all looked good to me
Author has addressed the following