Skip to content
This repository has been archived by the owner on Feb 7, 2023. It is now read-only.

Add missing properties that can be in the cf object on an event.request #23

Closed
2 of 7 tasks
ispivey opened this issue May 14, 2020 · 4 comments
Closed
2 of 7 tasks
Milestone

Comments

@ispivey
Copy link
Contributor

ispivey commented May 14, 2020

We should add missing properties that are documented here: https://developers.cloudflare.com/workers/reference/apis/request/

These should be added to the CfRequestProperties interface.

We should also update the interface to reflect that much of the geolocation information is optional, and may not be present on every request.

Missing properties:

  • clientTcpRtt
  • metroCode
  • isEuCountry (not documented yet)
  • weight
  • exclusive
  • group
  • group-weight
@ispivey
Copy link
Contributor Author

ispivey commented May 15, 2020

... do we actually include group, group-weigh, weight and exclusive ? I haven't been able to reproduce that myself, even using Firefox. I just see those fields as part of the requestPriority string property, like "requestPriority": "weight=42;exclusive=0;group=13;group-weight=241",

@ispivey
Copy link
Contributor Author

ispivey commented May 15, 2020

I'm going to close this as complete for now. I'll file a follow-up for isEuCountry.

@ispivey ispivey closed this as completed May 15, 2020
@harrishancock
Copy link

I suspect the group and friends were implemented as documented, then documented, then refactored. :/

@fixingitnow
Copy link

@ispivey I"m trying to use isEUCountry, but seeing this error
'isEUCountry' does not exist on type 'CloudflareRequestAttributes'
did you get a chance to add it to the interface?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants