Skip to content
This repository has been archived by the owner on Feb 7, 2023. It is now read-only.

Adds some missing CfRequestProperties and makes others optional #24

Merged
merged 2 commits into from
May 15, 2020

Conversation

ispivey
Copy link
Contributor

@ispivey ispivey commented May 14, 2020

  • Geolocation properties are not guaranteed to be present.
  • asn is a number. I verified this by running wrangler tail against production data, and noting that it is serialized to a number, not a string.
  • Added new-ish clientTcpRtt field.

Geolocation properties, in particular, are not guaranteed to be present.
@ispivey ispivey added this to the Release 1.0.10 milestone May 14, 2020
@ispivey
Copy link
Contributor Author

ispivey commented May 14, 2020

This is part of #23 .

Copy link

@harrishancock harrishancock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we could add a couple more: metroCode and isEUCountry, which should come along with city, continent, etc. I'm not sure which types they are, though, and this PR is already a strict improvement.

@ispivey ispivey merged commit bd2b6ee into master May 15, 2020
@threepointone threepointone deleted the update-request-properties branch November 2, 2021 10:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants