This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
Adding missing types in RequestInitCfPropertiesImage
#156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregBrimble
reviewed
Nov 20, 2021
Removed, as they were brought over by the |
GregBrimble
suggested changes
Nov 20, 2021
There was a problem hiding this comment.
And lastly, if you can update the crop docs on L55 to be:
* - crop: The image will shrunk and cropped to fit within the area
* specified by width and height. The image will not be enlarged. For images
* smaller than the given dimensions it is the same as scale-down. For
* images larger than the given dimensions, it is the same as cover.
* See also trim.
Thanks for contributing!
|
Fixes requested, done. |
GregBrimble
approved these changes
Nov 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing types with descriptions.
Added, described and ordered following the Cloudflare Developer Docs at https://developers.cloudflare.com/images/image-resizing/resize-with-workers and https://developers.cloudflare.com/images/image-resizing/draw-overlays.
In
RequestInitCfPropertiesImage:trimanimsharpenblurIn
RequestInitCfPropertiesImageDraw:widthheightfitgravitybackgroundrotateAdded
RequestInitCfPropertiesImageTrim:lefttoprightbottomCloses #141.