fix: semver comparison (#216)

* fix: semver comparison chore: bump dependencies * chore: add changeset * fix: update snapshot for error test
cloudflare · Dec 13, 2023 · 9aba9c3 · 9aba9c3
1 parent 65996a5
commit 9aba9c3
Show file tree

Hide file tree

Showing 5 changed files with 1,116 additions and 602 deletions.
diff --git a/.changeset/weak-lobsters-march.md b/.changeset/weak-lobsters-march.md
@@ -0,0 +1,9 @@
+---
+"wrangler-action": patch
+---
+
+Fixes issues with semver comparison, where version parts were treated lexicographically instead of numerically.
+
+Bulk secret uploading was introduced in wrangler `3.4.0`, and this action tries to check if the version used is greater than `3.4.0`, and then if so, using the new bulk secret API which is faster. Due to a bug in the semver comparison, `3.19.0` was being considered less than `3.4.0`, and then using an older and slower method for uploading secrets.
+
+Now the semver comparison is fixed, the faster bulk method is used for uploading secrets when available.